8 Commits
Author SHA1 Message Date
akarki15 fedde804e3 Remove error return value from ConvertToOptions
ConvertToOptions can't return any error.
2016-11-15 22:03:32 -05:00
akarki15 b1fdbf714b Make assets. 2016-11-12 13:19:09 -05:00
akarki15 68db934507 Use generic typed error pattern
The codebase doesn't yet use the explicitly typed error pattern. To keep
things consistent, lets use the generic error type.
2016-11-12 12:30:15 -05:00
akarki15 1b4902f196 initClient uses bookmark if it exists
if options.Bookmark is set, initClient will now use
it to create a client from the bookmarked settings.

initClientUsingBookmark uses methods introduced in
previous commits. It constructs connection string
to db from Bookmark.Url if it exists. If not, it
uses other fields in Bookmark to construct the
connection string. An implication of this is that
the Url field of Bookmark takes precedence.
2016-11-10 20:06:39 -05:00
akarki15 61dfe67ca8 Add a method to convert bookmark to options
We will use client.NewFromURL to create a client
from stored bookmark in next commit. Since
client.NewFromURL takes in a command.Options, lets
add a method on Bookmark to get corresponding Option.
2016-11-10 20:06:39 -05:00
akarki15 038cb620c6 Set the type of Bookmark.Port to int
We know that a port is a number. Lets enforce that
rule at type level by setting it so.

This commit also adjusts test funcs and helper data
to fit Port's new int type.
2016-11-10 20:06:39 -05:00
akarki15 0e88e3e1f4 Add a func to read bookmark from stored toml file
Given a bookmark path and bookmark name, GetBookmark
returns a Bookmark object that corresponds to the
stored bookmark settings.

In next commits, we will use this method to read
stored bookmarks and create a db client.
2016-11-10 20:06:39 -05:00
akarki15 f4fb5744ef Add method that returns if bookmark's ssh is empty
We will use this method in upcoming commit to create
client from stored bookmark.
2016-11-10 20:06:39 -05:00