balki/collage-maker
1
0
Fork 0
Code Issues 10 Pull Requests Packages Projects Releases Wiki Activity

Implement selecting template for collage #14

Merged
balki merged 6 commits from template-chooser into main 2023-09-06 23:59:07 -04:00
Conversation 0 Commits 6 Files Changed 4 +13 -21
1 changed files with 13 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit b7fe2e8192 - Show all commits

34
web/index.html
View File

@ -21,13 +21,13 @@
<label> <label>
<span>Paper size</span> <span>Paper size</span>
<select id="page_size_selector" size=8 onChange="pageSizeChange(this)"> <select id="page_size_selector" size=8>
balki marked this conversation as resolved Outdated
balki commented 2023-09-06 23:48:58 -04:00
Outdated
Review
Copy Link

remove onChange

remove onChange
<option value="letter-portrait">Letter (Portrait)</option> <option value="letter-portrait">Letter (Portrait)</option>
<option selected value="letter-landscape">Letter (Landscape)</option> <option selected value="letter-landscape">Letter (Landscape)</option>
<option value="fiveseven-portrait">5 X 7 (Portrait)</option> <option value="fiveseven-portrait">5 × 7 (Portrait)</option>
<option value="fiveseven-landscape">7 X 5 (Landscape)</option> <option value="fiveseven-landscape">7 × 5 (Landscape)</option>
<option value="foursix-portrait">4 X 6 (Portrait)</option> <option value="foursix-portrait">4 × 6 (Portrait)</option>
<option value="foursix-landscape">4 X 6 (Landscape)</option> <option value="foursix-landscape">4 × 6 (Landscape)</option>
</select> </select>
</label> </label>
@ -35,34 +35,26 @@
<ul class="templates"> <ul class="templates">
<li> <li>
<div id="default_template" class="template single" data-collage-template="single"> <div id="default_template" class="template single" data-collage-template="single">
<div class="img img1"> <div class="img img1"></div>
balki marked this conversation as resolved Outdated
balki commented 2023-09-06 23:49:54 -04:00
Outdated
Review
Copy Link

Remove empty line inside div

Remove empty line inside div
</div>
</div> </div>
</li> </li>
<li> <li>
<div class="template one-two" data-collage-template="one-two"> <div class="template one-two" data-collage-template="one-two">
<div class="img img1"> <div class="img img1"></div>
</div> <div class="img img2"></div>
<div class="img img2"> <div class="img img3"></div>
</div>
<div class="img img3">
</div>
</div> </div>
</li> </li>
<li> <li>
<div class="template half-leftright" data-collage-template="half-leftright"> <div class="template half-leftright" data-collage-template="half-leftright">
<div class="img img1"> <div class="img img1"></div>
</div> <div class="img img2"></div>
<div class="img img2">
</div>
</div> </div>
</li> </li>
<li> <li>
<div class="template half-topbottom" data-collage-template="half-topbottom"> <div class="template half-topbottom" data-collage-template="half-topbottom">
<div class="img img1"> <div class="img img1"></div>
</div> <div class="img img2"></div>
<div class="img img2">
</div>
</div> </div>
</li> </li>
<li> <li>