Merge pull request #605 from sosedoff/log-level

Configure logging level and format

pkg/api/logger.go

@@ -55,6 +55,7 @@ func RequestLogger(logger *logrus.Logger) gin.HandlerFunc {
 			"method":      c.Request.Method,
 			"remote_addr": c.ClientIP(),
 			"duration":    latency,
+			"path":        path,
 		}
 
 		if err := c.Errors.Last(); err != nil {
@@ -64,10 +65,14 @@ func RequestLogger(logger *logrus.Logger) gin.HandlerFunc {
 		// Additional fields for debugging
 		if debug {
 			fields["raw_query"] = c.Request.URL.RawQuery
+
+			if c.Request.Method != http.MethodGet {
+				fields["raw_form"] = c.Request.Form
+			}
 		}
 
-		entry := logrus.WithFields(fields)
+		entry := logger.WithFields(fields)
-		msg := "http_request " + path
+		msg := "http_request"
 
 		switch {
 		case status >= http.StatusBadRequest && status < http.StatusInternalServerError:

pkg/api/middleware.go

@@ -1,7 +1,6 @@
 package api
 
 import (
-	"log"
 	"strings"
 
 	"github.com/gin-gonic/gin"
@@ -49,14 +48,6 @@ func dbCheckMiddleware() gin.HandlerFunc {
 	}
 }
 
-// Middleware to print out request parameters and body for debugging
-func requestInspectMiddleware() gin.HandlerFunc {
-	return func(c *gin.Context) {
-		err := c.Request.ParseForm()
-		log.Println("Request params:", err, c.Request.Form)
-	}
-}
-
 // Middleware to inject CORS headers
 func corsMiddleware() gin.HandlerFunc {
 	return func(c *gin.Context) {

pkg/api/routes.go

@@ -7,10 +7,6 @@ import (
 )
 
 func SetupMiddlewares(group *gin.RouterGroup) {
-	if command.Opts.Debug {
-		group.Use(requestInspectMiddleware())
-	}
-
 	if command.Opts.Cors {
 		group.Use(corsMiddleware())
 	}

pkg/cli/cli.go

@@ -158,8 +158,9 @@ func initOptions() {
 		os.Exit(0)
 	}
 
-	if options.Debug {
+	if err := configureLogger(opts); err != nil {
-		logger.SetLevel(logrus.DebugLevel)
+		exitWithMessage(err.Error())
+		return
 	}
 
 	if options.ReadOnly {
@@ -175,6 +176,29 @@ func initOptions() {
 	printVersion()
 }
 
+func configureLogger(opts command.Options) error {
+	if options.Debug {
+		logger.SetLevel(logrus.DebugLevel)
+	} else {
+		lvl, err := logrus.ParseLevel(opts.LogLevel)
+		if err != nil {
+			return err
+		}
+		logger.SetLevel(lvl)
+	}
+
+	switch options.LogFormat {
+	case "text":
+		logger.SetFormatter(&logrus.TextFormatter{})
+	case "json":
+		logger.SetFormatter(&logrus.JSONFormatter{})
+	default:
+		return fmt.Errorf("invalid logger format: %v", options.LogFormat)
+	}
+
+	return nil
+}
+
 func printVersion() {
 	fmt.Println(command.VersionString())
 }

pkg/command/options.go

@@ -8,6 +8,7 @@ import (
 	"strings"
 
 	"github.com/jessevdk/go-flags"
+	"github.com/sirupsen/logrus"
 )
 
 const (
@@ -18,6 +19,8 @@ const (
 type Options struct {
 	Version                      bool   `short:"v" long:"version" description:"Print version"`
 	Debug                        bool   `short:"d" long:"debug" description:"Enable debugging mode"`
+	LogLevel                     string `long:"log-level" description:"Logging level" default:"info"`
+	LogFormat                    string `long:"log-format" description:"Logging output format" default:"text"`
 	URL                          string `long:"url" description:"Database connection string"`
 	Host                         string `long:"host" description:"Server hostname or IP" default:"localhost"`
 	Port                         int    `long:"port" description:"Server port" default:"5432"`
@@ -62,6 +65,11 @@ func ParseOptions(args []string) (Options, error) {
 		return opts, err
 	}
 
+	_, err = logrus.ParseLevel(opts.LogLevel)
+	if err != nil {
+		return opts, err
+	}
+
 	if opts.URL == "" {
 		opts.URL = getPrefixedEnvVar("DATABASE_URL")
 	}