balki/pgweb
1
0
Fork 0
Code Pull Requests Activity

Drop unsupported pg_dump options from connection string

Browse Source
This commit is contained in:
Dan Sosedoff
2019-09-25 20:29:21 -05:00
parent d5e4a10137
commit b6f01da232
2 changed files with 44 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/client/dump_test.go
View File

@@ -34,8 +34,8 @@ func testDumpExport(t *testing.T) {
assert.NoError(t, err)
// Test nonexistent database
invalidUrl := fmt.Sprintf("postgres://%s@%s:%s/%s?sslmode=disable", serverUser, serverHost, serverPort, "foobar")
err = dump.Export(invalidUrl, saveFile)
invalidURL := fmt.Sprintf("postgres://%s@%s:%s/%s?sslmode=disable", serverUser, serverHost, serverPort, "foobar")
err = dump.Export(invalidURL, saveFile)
assert.Contains(t, err.Error(), `database "foobar" does not exist`)
// Test dump of non existent db
@@ -43,4 +43,10 @@ func testDumpExport(t *testing.T) {
err = dump.Export(url, saveFile)
assert.NotNil(t, err)
assert.Contains(t, err.Error(), "pg_dump: no matching tables were found")
// Should drop "search_path" param from URI
dump = Dump{}
searchPathURL := fmt.Sprintf("postgres://%s@%s:%s/%s?sslmode=disable&search_path=private", serverUser, serverHost, serverPort, serverDatabase)
err = dump.Export(searchPathURL, saveFile)
assert.NoError(t, err)
}