From 951bec859671f0be3dcf1999f8f69b18effc1c87 Mon Sep 17 00:00:00 2001 From: Dan Sosedoff Date: Fri, 22 Jan 2016 12:12:00 -0600 Subject: [PATCH] Go vet --- pkg/client/tunnel.go | 4 ++-- pkg/connection/port_test.go | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/client/tunnel.go b/pkg/client/tunnel.go index aaeb4ff..df9a82f 100644 --- a/pkg/client/tunnel.go +++ b/pkg/client/tunnel.go @@ -132,6 +132,8 @@ func (tunnel *Tunnel) Configure() error { } func (tunnel *Tunnel) Start() { + defer tunnel.Close() + for { conn, err := tunnel.Listener.Accept() if err != nil { @@ -140,8 +142,6 @@ func (tunnel *Tunnel) Start() { go tunnel.handleConnection(conn) } - - tunnel.Close() } func NewTunnel(sshInfo *shared.SSHInfo, dbUrl string) (*Tunnel, error) { diff --git a/pkg/connection/port_test.go b/pkg/connection/port_test.go index 66a0375..b1a171e 100644 --- a/pkg/connection/port_test.go +++ b/pkg/connection/port_test.go @@ -19,7 +19,7 @@ func Test_portAvailable(t *testing.T) { serv, err := net.Listen("tcp", "127.0.0.1:8081") if err != nil { - fmt.Println(os.Stderr, "Unable to start test tcp listener:", err) + fmt.Fprintln(os.Stderr, "Unable to start test tcp listener:", err) t.Fail() return } @@ -50,7 +50,7 @@ func Test_getAvailablePort(t *testing.T) { serv, err := net.Listen("tcp", "127.0.0.1:8081") if err != nil { - fmt.Println(os.Stderr, "Unable to start test tcp listener:", err) + fmt.Fprintln(os.Stderr, "Unable to start test tcp listener:", err) t.Fail() return }