Added binary codec base58 as well as improving the help for --binary-codec flag (#548)

* Added binary codec `base58` as well as improving the help for `--binary-codec` flag
* Added tests for base58
* Fixed tests

Co-authored-by: Matthieu Vachon <matt@streamingfast.io>

pkg/client/codec.go

@@ -4,11 +4,14 @@ import (
 	"encoding/base64"
 	"encoding/hex"
 	"fmt"
+
+	"github.com/mr-tron/base58"
 )
 
 const (
 	CodecNone   = "none"
 	CodecHex    = "hex"
+	CodecBase58 = "base58"
 	CodecBase64 = "base64"
 )
 
@@ -19,7 +22,7 @@ var (
 
 func SetBinaryCodec(codec string) error {
 	switch codec {
-	case CodecNone, CodecHex, CodecBase64:
+	case CodecNone, CodecHex, CodecBase58, CodecBase64:
 		BinaryCodec = codec
 	default:
 		return fmt.Errorf("invalid binary codec: %v", codec)
@@ -32,6 +35,8 @@ func encodeBinaryData(data []byte, codec string) string {
 	switch codec {
 	case CodecHex:
 		return hex.EncodeToString(data)
+	case CodecBase58:
+		return base58.Encode(data)
 	case CodecBase64:
 		return base64.StdEncoding.EncodeToString(data)
 	default:

pkg/client/codec_test.go

@@ -13,6 +13,7 @@ func TestSetBinaryCodec(t *testing.T) {
 		err   error
 	}{
 		{input: CodecNone, err: nil},
+		{input: CodecBase58, err: nil},
 		{input: CodecBase64, err: nil},
 		{input: CodecHex, err: nil},
 		{input: "foobar", err: errors.New("invalid binary codec: foobar")},
@@ -37,6 +38,7 @@ func Test_encodeBinaryData(t *testing.T) {
 		encoding string
 	}{
 		{input: "hello world", expected: "hello world", encoding: CodecNone},
+		{input: "hello world", expected: "StV1DL6CwTryKyV", encoding: CodecBase58},
 		{input: "hello world", expected: "aGVsbG8gd29ybGQ=", encoding: CodecBase64},
 		{input: "hello world", expected: "68656c6c6f20776f726c64", encoding: CodecHex},
 	}