balki/pgweb
1
0
Fork 0
Code Pull Requests Activity

Perform client version validation before executing pg_dump command (#614)

Browse Source 
* Add func to parse out pg_dump version
* Perform client vs server version checking before dump exports
* Fix dump tests
* Add extra test to validate against empty server version
* Fix attachment filenames cleanup function
* Add extra test
* Fix small typos in comments
* Drop third-party package to deal with versions
* Tweak the pg dump incompatibility error message
* Run CI on pull requests
This commit is contained in:
Dan Sosedoff
2022-12-12 15:09:12 -06:00
committed by GitHub
parent 7557ac854e
commit 4c40eef99a
15 changed files with 185 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/client/tunnel.go
View File

@@ -85,7 +85,7 @@ func makeConfig(info *shared.SSHInfo) (*ssh.ClientConfig, error) {
return nil, errors.New("ssh public key not found at " + keyPath)
}
// Appen public key authentication method
// Append public key authentication method
key, err := parsePrivateKey(keyPath, info.KeyPassword)
if err != nil {
return nil, err